Skip to content

Ports- Amy M. & Steph#22

Open
smarchante1 wants to merge 71 commits intoAda-C11:masterfrom
smarchante1:master
Open

Ports- Amy M. & Steph#22
smarchante1 wants to merge 71 commits intoAda-C11:masterfrom
smarchante1:master

Conversation

@smarchante1
Copy link
Copy Markdown

@smarchante1 smarchante1 commented Jun 28, 2019 •
edited
Loading

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#14
For each person in your pair, describe something you learned from your partner during this project I learned from Amy that it is very helpful at times to create helper functions when expanding functionality of components i.d. filterMovies. I learned a lot of amazing CSS strategies from Steph, and also learned a lot from they way they approached partnership and sharing workload.
What was one area of React you gained more clarity on during this assignment? That arrow functions are an essential part of callback methods, and literally EVERYTHING WILL BREAK if you're not referencing the correct 'this.'
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We created the component MovieCard that we rendered in both our Library and our Search components.
Describe how you handled rentals with React We made an API call to the Rails API to their checkout route, that created a new Rental object within the Rails database. We then displayed a success message and reset the state of "selected" items to null.
Describe a DOM event your application handled When you add a movie to the library from the external API, we refreshed the state within the API call in order to re-render the DOM so that the new movie would show up in our Library.
Did you use any functional stateless components? What for? We held our state in App and Search, and all other components were functional/presentational. Felt great.
Did you use any container components? What for? Yes, we used our App component as a container. It holds the data that we send to child components and also performs the methods for selecting and filtering that data.
Do you have any recommendations on how we could improve this project for the next cohort? Elaborate on the role of the intermediary rails Api before introducing the project. Give the students a deeper understanding of the expectations of communication between the front and back ends. Also please remove bugs from code please! :) <3

smarchante1 and others added 30 commits June 24, 2019 15:22
@smarchante1
added state to app and skeleton for functions
818d0ec
@smarchante1
added skeleton for all components in mock design
a7ef58f
@smarchante1
added movie card functional component
8acd766
@smarchante1
added react routes to render all components
e6bb48e
@amyesh
created API request to fetch all movie json data
4f21b84
@amyesh
added API call to fetch all customers
4a08ad1
@amyesh
added API requests to find movie by title and search movies by word
6733455
@smarchante1
added onFormSubmit function
f37d076
@amyesh
fixed typo
89af3cf
@amyesh
Merge branch 'master' of https://github.com/smarchante1/video-store-c…
200418c 
…onsumer

merged stephs edit
@smarchante1
functional search bar
4cf02b0
@amyesh
passed props into customerList
a85701e
@amyesh
Merge branch 'master' into customers
cd4be74
@amyesh
merged updates from master
58c18cf
@smarchante1
finalized search functionality and MovieCard component
73eae79
@amyesh
added movieCard display
486ad0a
@amyesh
merged conflicts
cb5c2a1
@smarchante1
Click handler for select movie and appropriate state changes
1251852
@smarchante1
click handler for select customer and appropriate state changes which…
0c15ec8 
… propogates
@amyesh
working through adding to library
0259d61
@amyesh
working through adding movie to rails server
4152f47
@smarchante1
made changes to add movie function bug with displaying MovieCard
29d8a12
@amyesh
added method to checkout movie
d2147c5
@amyesh
fixed post request to successfully add data to rails server
f11a48d
@amyesh
changed Library to classical component to render state
a4cb56d
@smarchante1
rendering selected movie object
84ed048
@smarchante1
changed function to select customer object
0c0fcc9
@smarchante1
added user messages to app state
e3ff093
@smarchante1
added proptypes and messages section
ab1dc29
@smarchante1
removed i from search results map
f8132ee
amyesh and others added 30 commits June 26, 2019 21:52
@amyesh
added form clearing functionality to search
24c0926
@amyesh
debugging search function
e5372e2
@amyesh
internal server error present
27f3c40
@amyesh
Merge branch 'master' of https://github.com/smarchante1/video-store-c…
f1fea20 
…onsumer
@amyesh
added bootstrap
ab3719a
@smarchante1
added bootstrap
22b75f4
@smarchante1
basic movie card styling
a72cfc2
@amyesh
added navbar styling
8f6d287
@amyesh
Merge branch 'master' of https://github.com/smarchante1/video-store-c…
d42ab9c 
…onsumer
@smarchante1
movie library grid under constructtion
87415f0
@amyesh
Merge branch 'master' of https://github.com/smarchante1/video-store-c…
9326f95 
…onsumer
@amyesh
changed button styling
a32e4ae
@smarchante1
movie card title changes and rearranging description
b6bca35
@amyesh
Merge branch 'master' of https://github.com/smarchante1/video-store-c…
9a4bd0f 
…onsumer
@smarchante1
basic styling for cards in card columns
c6fde59
@amyesh
added styling to nav bar and homepage
a08c0d6
@smarchante1
movie cards flip style working
99196b9
@amyesh
added table styling to customer list
6a18710
@smarchante1
added cursor and blue shadow to movie cards
3d68f93
@amyesh
added styling to selected items
a9fa35e
@smarchante1
changed the height of movie cards so text won't overflow
a72148c
@smarchante1
overrode bootstrap styles with styling in app css
0b3cee5
@smarchante1
fixing merge conflicts
5343ff6
@amyesh
minor changes to styling
edde30a
@smarchante1
changed color of movie overview text
81dacf1
@smarchante1
fixed search bar style
5ccbedc
@amyesh
updated card container and selected margin styling
a2fac6b
@amyesh
merged conflicts
74a9fa3
@amyesh
fixed search styling
3c60e9d
@amyesh
cleaned up comments
703527c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smarchante1 @amyesh